Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally intended to address #170 but is an alternative fix to the solution proposed in #162. It turns out that the data in the message contains the original host header and is passed on to the target as a header. I think that rewriting it is better than removing it (proposed in #170) as it makes it possible or smee client to work behind a reverse proxy (nginx, like Laravel Valet) or some Docker environments (using something like traefik as I am).
Relatively new to typescript, Node.js, and jest at this level, so unclear if there was a better way to handle the testing. The issue I ran into was the logging output in the success handler.
I couldn't find out a way to get around this issue without either 1) making logging optional, 2) including an additional optional callback so that we could call it when the response was completed 3) ???. So, I opted to fake it for now.
If there is a better way for me to do this let me know!