Update Synth_Dexed and support Sostenuto pedal

[probonopd]

Hopefully closes #624

[probonopd]

Do you have an idea what is going wrong here @soyersoyer? Thanks for your help.

[soyersoyer]

I think this one is the culprit:
https://codeberg.org/dcoredump/Synth_Dexed/commit/54e543143f2d0c89e6ba7254c8cfccc87b65c32a

Probably the int is 16 bit in teensy and they want to use the 32 bit one? And on rpi2 the int32_t and the int is different type.
But the TEENSYDUINO doesn't use the compressor, so I think we can revert the types in that file.

I'll check it.

[soyersoyer]

https://codeberg.org/dcoredump/Synth_Dexed/pulls/9

[probonopd]

Hmmm. The error slightly changed. Possibly this needs to be applied in more than one place? Does it build for you?

[soyersoyer]

hmm, yes it worked for me.

sed -i -e 's|int E;|int32_t E;|g' Synth_Dexed/src/compressor.h # https://codeberg.org/dcoredump/Synth_Dexed/pulls/9
this should be:
sed -i -e 's|int32_t E;|int E;|g' Synth_Dexed/src/compressor.h # https://codeberg.org/dcoredump/Synth_Dexed/pulls/9

[probonopd]

Stupid me!

[soyersoyer]

soyersoyer@882d6c0 this still needs
If you merge this, I can create a PR. Or pick this commit also.

[github-actions]

Build for testing:
MiniDexed_2024-11-09-d4cf90c
Use at your own risk.

[probonopd]

@Kirtai please try with the version linked above - does it work for you?

[diyelectromusic]

I would strongly recommend that we don't include changes that mean that the system can no longer be built using the build.sh and make in the src area. Patching source code "on the fly" is a really bad idea in my view.

I know that change to build.yml is described as a temporary fix, but as I say having external dependencies outside of the main build/make system to my mind is storing up dependency problems for the future. It will certainly make developing and building changes to the code messier and less obvious what is going on.

So, please can this not be merged in until that patching is not required.

Kevin

[probonopd]

Note to self: only merge after the temporary fix can be removed once https://codeberg.org/dcoredump/Synth_Dexed/pulls/9 is merged.

We can nevertheless test and polish this PR in the meantime 👍

[Kirtai]

@Kirtai please try with the version linked above - does it work for you?

The initial sostenuto works but it stops as soon as I play another key and turns into sustain.

What happens.

1. Play a chord.
2. Press pedal.
3. Release chord.
4. Chord is correctly sustained.
5. Play another note.
6. Chord is silenced.
7. New note and following ones are sustained.
8. Release pedal, all sounds end.

What should happen.

1. Play a chord.
2. Press pedal.
3. Release chord.
4. Chord is correctly sustained.
5. Play another note.
6. Chord remains sustained.
7. New note and following ones are not sustained.
8. Release pedal, all sounds end.

Another problem is that pressing the pedal then playing a chord causes it to sustain. A sostenuto pedal is only supposed to sustain notes that are played when it is pressed.

[probonopd]

Hello @soyersoyer can you please have a look at the above? Would this need to be addressed in Synth_Dexed?

[probonopd]

Right now it seems to have a tendency for stuck notes (notes playing forever) when using an attached MIDI controller (keyboard).

To reproduce, just play a glissando up and down (put finger on keyboard and slide left and right all over the range of the keyboard).

#747 suffers from the same. Might updating circle be causing this?

Can anyone reproduce? (And can you reproduce that the same issue does not occur on the normal build?)

[soyersoyer]

The initial sostenuto works but it stops as soon as I play another key and turns into sustain.

Thank you for your invaluable review @Kirtai ! I did this based on the "hold" function of one of my controllers, which I thought was the same as sostenuto. By the way, that function is also fun, just not sostenuto. (And not all of my controllers know it.) I will update Synth_Dexed soon to make it work correctly.

[dcoredump]

Note to self: only merge after the temporary fix can be removed once https://codeberg.org/dcoredump/Synth_Dexed/pulls/9 is merged.

We can nevertheless test and polish this PR in the meantime 👍

Done

[soyersoyer]

https://codeberg.org/dcoredump/Synth_Dexed/pulls/10

[dcoredump]

https://codeberg.org/dcoredump/Synth_Dexed/pulls/10

PR merged in 919f71f938