Stabilize circom frontend #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ak satisfaction test
dmpierre
force-pushed
the
fix/circom-frontend
branch
from
2d7b897
to
99e7aac
Compare
arnaucube
requested changes
May 23, 2024
folding-schemes/src/frontend/circom/test_folder/keccak256-circom/circuits/keccak.circom
Outdated
Show resolved
Hide resolved
…s, test that circom circuits correctly result in Ok and Err when needed
arnaucube
reviewed
May 27, 2024
arnaucube
reviewed
May 28, 2024
arnaucube
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims at stabilizing sonobe's circom frontend. To do this we:
circom-compat. A PR on acircom-compatfork has been opened here to choose how our IVC inputs are allocated (as witnesses and public inputs) and to adjust circom's R1CS indexes when wrapped by ourAugmentedFCircuit.circom-compat.