Skip to content
This repository has been archived by the owner on Oct 23, 2018. It is now read-only.

[WIP] Adds minimal boilerplate #72

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[WIP] Adds minimal boilerplate #72

wants to merge 4 commits into from

Conversation

DevanB
Copy link
Collaborator

@DevanB DevanB commented Jan 7, 2018

Please test to verify all is working!

@DevanB DevanB requested a review from marktani January 7, 2018 16:42
Copy link
Contributor

@marktani marktani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running the app results in errors

Unhandled (in react-apollo:Apollo(Home)) Error: Network error: Network request failed

@DevanB
Copy link
Collaborator Author

DevanB commented Jan 13, 2018

@marktani

This error is nasty and really should be handled in a more graceful way, but is being debated over in the react-apollo ticket (#604)

In the meantime, it seems you didn't have the server running.

This leads me to propose that we make sure the start script starts up possibly nodemon to start up the Expo packager and the server.

Thoughts?

@marktani
Copy link
Contributor

I definitely had the server running, but I can't say if I started the app first. Is that a problem?

@DevanB
Copy link
Collaborator Author

DevanB commented Jan 13, 2018 via email

@marktani
Copy link
Contributor

marktani commented Jan 13, 2018

Thanks I'll try that again 🙂

For the record, I am using a real Android device, if that makes a difference.

@DevanB
Copy link
Collaborator Author

DevanB commented Jan 13, 2018 via email

@DevanB
Copy link
Collaborator Author

DevanB commented Feb 7, 2018

Hmm, updated the Expo and the server locally tonight, and am seeing the same problem again. I now know that the problem is a network error, but haven't tracked down why the ApolloClient can't talk with the server when they are both running...

@DevanB DevanB changed the title Adds minimal boilerplate. [WIP] Adds minimal boilerplate Feb 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging this pull request may close these issues.

2 participants