-
Notifications
You must be signed in to change notification settings - Fork 62
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #482 from Jozian/data-migration-gbv-calculated-fields
DAO: Data Migration for GBV Calculated Fields
- Loading branch information
Showing
2 changed files
with
43 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
# Migrations in 2.11.1 | ||
|
||
This migration updates the configuration of GBV instances *only*. This migrates the fields that calculate average scores on subforms to new versions which support decimal places. | ||
|
||
# Verification of data to be updated | ||
|
||
These scripts will update the `Field` records where calculations exist. | ||
|
||
To validate which fields will be updated, run the following: | ||
|
||
```bash | ||
rails r ./db/migrations/v2.11.1/update_calculated_avg_fields_gbv.rb | ||
``` |
30 changes: 30 additions & 0 deletions
30
db/data_migration/v2.11.1/update_calculated_avg_fields_gbv.rb
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
# frozen_string_literal: true | ||
|
||
save_records = ARGV[0] == 'true' | ||
|
||
def fields_with_old_avg_calculations | ||
return unless PrimeroModule.exists? unique_id: PrimeroModule::GBV | ||
|
||
avg_fields = Field.where("calculation -> 'expression' ? 'avg'") | ||
# The new type of calculated average field has the avg object as a hash, not an array. | ||
avg_fields.filter { |f| f.calculation.dig('expression', 'avg').is_a?(Array) } | ||
end | ||
|
||
def migrate_field(orig_field, save) | ||
old_avg_data = orig_field.calculation.dig('expression', 'avg') | ||
new_field = orig_field.dup | ||
new_field.calculation = { type: 'number', expression: { avg: { data: old_avg_data, extra: { decimalPlaces: 2 } } } } | ||
new_field.disabled = true | ||
new_field.type = 'calculated' | ||
if save | ||
# We because the type of a field cannot be changed, we need to destroy and recreate | ||
orig_field.destroy! | ||
new_field.save! | ||
puts "Updated field #{new_field.name}" | ||
else | ||
puts "Would update #{new_field.name} to the following" | ||
puts new_field.inspect | ||
end | ||
end | ||
|
||
fields_with_old_avg_calculations.each { |f| migrate_field(f, save_records) } |