fix: add an extra condition for tryOnMounted method #6454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
tugcekucukoglu
added
the
Resolution: Help Wanted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For issue #6453
This pull request includes an extra condition for tryOnMounted. It was made because getCurrentInstance returns an object that could have a isMounted: true flag value, but the value of the Vue application context properties, for example, 'components', could have null. So this fix is useful for module federation and can fix CSS variables problems that I described in the issue ahead.
This change improves the problem with CSS rules applying. There are some pictures before and after changes. It's from my MF Primevue example https://github.com/andrew-cmdltt/primevue-4-vite-issue-template-mf.
Before:
After:
So now these CSS rules are not undefined and attached to the head: