feat (v18): Modernize toggleswitch and expand test #16598
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
Comment on lines
116
to
125
| trueValue = input<boolean, any>(true, { transform: booleanAttribute }); | ||
| /** | ||
| * Value in unchecked state. | ||
| * @group Props | ||
| */ | ||
| @Input() falseValue: any = false; | ||
| falseValue = input<boolean, any>(false, { transform: booleanAttribute }); | ||
| /** | ||
| * Used to define a string that autocomplete attribute the current element. | ||
| * @group Props | ||
| */ |
There was a problem hiding this comment.
should't be transformed to boolean. These options give us ability to use different checked and unchecked values other than true and false. It can be string, number, ... anything.
There was a problem hiding this comment.
Thanks @vladovelichkovski for your feedback! I just address it in my last commit.
# Conflicts: # packages/primeng/src/toggleswitch/toggleswitch.spec.ts # packages/primeng/src/toggleswitch/toggleswitch.ts
mertsincan
added
the
Status: Discussion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor:
Updated the ToggleSwitch component to leverage Angular's new signal-based inputs for enhanced reactivity and performance optimization.
Test Cases: Added comprehensive test cases to cover:
Dynamic input handling (label, icon, image)
Inline styles and CSS class binding
Size variations (normal, large, xlarge)
Shape variations (square, circle)
Error handling for image loading
Accessibility (aria-label, aria-labelledby)
Custom styling and class inputs (styleClass, style)
Fix #16546