-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds new feature - Avatar support image and label together #16157
Open
EnricoMessall
wants to merge
7
commits into
primefaces:master
Choose a base branch
from
Arematics:avatar-labelwithimage
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
SoyDiego
reviewed
Aug 2, 2024
SoyDiego
reviewed
Aug 2, 2024
SoyDiego
approved these changes
Aug 2, 2024
Info for prime team: Currently the component uses a image from my domain to display the doc informations. Should be replaced with Prime CDN probably before merging :) |
cetincakiroglu
added
the
Type: Enhancement
Issue contains an enhancement related to a specific component. Additional functionality has been add
label
Aug 8, 2024
Hi @EnricoMessall, Thanks for the effort and support! Could you please open an issue and tag me so I can add it to the v18.0.0-rc.1 milestone |
cetincakiroglu
added
the
Resolution: Needs Issue
An issue needs to be created for the pull request
label
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Resolution: Needs Issue
An issue needs to be created for the pull request
Type: Enhancement
Issue contains an enhancement related to a specific component. Additional functionality has been add
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature Requests
Support image and label together for avatar.
Matching discussion with more informations:
https://github.com/orgs/primefaces/discussions/2435