Fixes buyer_order date time validation error #23
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ime property name to the one of SellerOrderReferenceDocument and make it use FormattedDateTimeField to fix Issue pretix#22
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #23 +/- ##
==========================================
- Coverage 91.09% 89.93% -1.17%
==========================================
Files 17 17
Lines 1382 1431 +49
==========================================
+ Hits 1259 1287 +28
- Misses 123 144 +21 ☔ View full report in Codecov by Sentry. |
raphaelm
reviewed
Jan 19, 2024
| def __init__(self, namespace, tag, value=None, format="102"): | ||
| super().__init__(namespace, tag) | ||
| self._value = value | ||
| self._format = format |
There was a problem hiding this comment.
This class looks good, but it is the kind of code that would profit from a few extra tests to make sure the format conversions are correct back and forth. would you mind adding those?
|
Replaced by the more general PR #27. Note that PR #27 also adds a test case. As I couldn't find one in the wild I 'constructed' one by adding to the while all Maybe all sample files should be updated to the latest revision from the v2.2 spec. |
raphaelm
pushed a commit
that referenced
this pull request
Mar 10, 2024
… and PR #23 and contains alignments to the v2.2 specification (#27) * - corrects the NS_QDT name according to the zugferd22 specification - extends elements.py:DateTimeElement to allow the adjustment of the inner DateTimes namespace - updates references.py:ReferencedDocument to use NS_QDT for its DateTimeElement - corrects profiles in reference.py for various attributes according to the zugferd22 schemata - adds test zugferd_2p2_EN16931_ElektronischeAdresse2.xml as a variation of the official zugferd22 sample EN16931_ElektronischeAdresse.xml adding a FormattedIssueDateTime to the BuyerOrderReferencedDocument - moves SellerOrderReferencedDocument from trade.py to references.py - fixes DateTimeField namespace of AdvancePayment.received_date * This commit also adds the class ProductInstance (IndividualTradeProductInstance) to product.py and adds the missing fields "id" (IDField) and "instance" (ProductInstance) to product.py:TradeProduct. This commit also adds class PayerTradeParty (PayerTradeParty) to party.py and adds the missing field "payer" (PayerTradeParty) to trade.py:TradeSettlement. This commit also removes the unused (and not needed) party.py:LineApplicableTradeTax class. This commit also corrects profile and required tags according to the v2.2 specification as follows: - references.py:LineAdditionalReferencedDocument .name profile COMFORT => BASIC (was COMFORT) - tradelines.py:LineSettlement .trade_tax profile COMFORT => BASIC .period profile COMFORT => BASIC .allowance_charge profile COMFORT => BASIC .monetary_summation profile COMFORT => BASIC .additional_referenced_document profile EXTENDED => COMFORT .accounting_account profile EXTENDED => COMFORT - product.py:ProductCharacteristic .type_code required => optional .description profile EXTENDED => COMFORT .value profile EXTENDED => COMFORT - product.py:ProductClassification .class_code required => optional; profile EXTENDED => COMFORT .value required => optional - product.py:TradeProduct .name profile COMFORT => BASIC .characteristics EXTENDED => COMFORT .classifications EXTENDED => COMFORT .origins EXTENDED => COMFORT - trade.py:TradeSettlement .tax_currency_code profile COMFORT => BASIC .invoicer profile COMFORT => EXTENDED .invoicee profile COMFORT => EXTENDED .payee profile COMFORT => BASIC .allowance_charge profile COMFORT => BASIC .service_charge profile COMFORT => EXTENDED .terms profile COMFORT => BASIC .accounting_account EXTENDED => BASIC - accounting.py:ApplicableTradeTax .exemption_reason COMFORT => BASIC .category_code COMFORT => BASIC .exemption_reason_code EXTENDED => BASIC * fixes profile annotations in TradeAllowanceCharge * SpecifiedTradeAllowanceCharge:ReasonCode in COMFORT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves BuyerOrderReferencedDocument to accounting.py, align the date time property name to the one of SellerOrderReferenceDocument and make it use FormattedDateTimeField to fix Issue #22.