Fixes some typos (Issue #10) (#11)

* Fixes some typos (Issue #10) * Apply suggestions from code review --------- Co-authored-by: Raphael Michel <[email protected]>
pretix · Sep 4, 2023 · 78b360d · 78b360d
1 parent 4a3e65a
commit 78b360d
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 9 deletions.
diff --git a/drafthorse/models/elements.py b/drafthorse/models/elements.py
@@ -106,7 +106,7 @@ def from_etree(self, root):
             if child.tag == ET.Comment:
                 continue
             if child.tag in field_index:
-                name, childel = field_index[child.tag]
+                name, _childel = field_index[child.tag]
                 if isinstance(getattr(self, name), Container):
                     getattr(self, name).add_from_etree(child)
                 else:
@@ -135,7 +135,7 @@ def __repr__(self):
         return "<{}: {}>".format(type(self).__name__, str(self))
 
     def __str__(self):
-        return str(self.text)
+        return str(self._text)
 
     def is_empty(self, el):
         return super().is_empty(el) and not self._set_on_input
@@ -165,7 +165,7 @@ def to_etree(self):
         return node
 
     def __str__(self):
-        return self.value
+        return self._value
 
     def from_etree(self, root):
         self._value = Decimal(root.text)
@@ -217,7 +217,7 @@ def from_etree(self, root):
         return self
 
     def __str__(self):
-        return "{} {}".format(self.amount, self.currency)
+        return "{} {}".format(self._amount, self._currency)
 
 
 class ClassificationElement(StringElement):
@@ -229,7 +229,7 @@ def __init__(self, namespace, tag, text="", list_id="", list_version_id=""):
 
     def to_etree(self):
         node = self._etree_node()
-        node.text = self.text
+        node.text = self._text
         node.attrib["listID"] = self._list_id
         node.attrib["listVersionID"] = self._list_version_id
         return node
@@ -267,7 +267,7 @@ def from_etree(self, root):
         return self
 
     def __str__(self):
-        return "{} ({} {})".format(self._text, self._mime_code)
+        return "{} ({} {})".format(self._text, self._filename, self._mime_code)
 
 
 class AgencyIDElement(StringElement):

diff --git a/drafthorse/models/tradelines.py b/drafthorse/models/tradelines.py
@@ -1,6 +1,5 @@
 from . import BASIC, COMFORT, EXTENDED, NS_RAM
 from .accounting import (
-    AccountingAccount,
     ApplicableTradeTax,
     BillingSpecifiedPeriod,
     ReceivableAccountingAccount,
@@ -9,7 +8,6 @@
 from .delivery import SupplyChainEvent
 from .elements import Element
 from .fields import (
-    DateTimeField,
     DecimalField,
     Field,
     MultiField,

diff --git a/drafthorse/pdf.py b/drafthorse/pdf.py
@@ -169,7 +169,7 @@ def _prepare_pdf_metadata_xml(level, pdf_metadata):
     xmp_file = os.path.join(
         os.path.dirname(__file__),
         "schema",
-        "ZUGFeRD2p2_extension_schema.xmp".format(level),
+        "ZUGFeRD2p2_extension_schema.xmp",
     )
     # Reason for defining a parser below:
     # http://lxml.de/FAQ.html#why-doesn-t-the-pretty-print-option-reformat-my-xml-output