Add support for HID QR code scanners to the pretixSCAN setup #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphaelm
reviewed
Oct 4, 2024
| @@ -128,6 +133,25 @@ class SetupActivity : AppCompatActivity(), ScannerView.ResultHandler { | |||
| handleScan(rawResult.text) | |||
| } | |||
|
|
|||
| override fun dispatchKeyEvent(event: KeyEvent): Boolean { | |||
There was a problem hiding this comment.
Is this intentionally a very different implementation than in MainActivity? Should we settle on one and maybe even move it to libpretixui?
There was a problem hiding this comment.
Whoops, yeah. I've seen the implementation in MainActivity only after this one, so, yep, combining them would be great. Maybe even moving not only the keyboardhandling, but the whole SetupActivity to libpretixui?
There was a problem hiding this comment.
Hmm, have they any differences currently?
robbi5
force-pushed
the
setup-by-keyboardinput
branch
from
839eccc
to
25b5eea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows people with an external usb qr code scanner that simply sends keyboard input to use it for setting up pretixSCAN instead of using the camera to scan it