Upgrade to SDK 34 #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uture print calls
raphaelm
approved these changes
Sep 11, 2024
Comment on lines
217
to
220
| if (instantGoToNextStep) { | ||
| (activity as PrinterSetupActivity).startProtocolChoice() | ||
| } | ||
| (activity as PrinterSetupActivity).startProtocolChoice() |
There was a problem hiding this comment.
This doesn't seem right? It just launches the startProtocolChoice twise? Why?
There was a problem hiding this comment.
aaah, yep. mis-clicked when chunking lines for seperate commits 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still need to test with usb/bluetooth devices if something breaks