-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve documentation of some SRAM routines #114
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rangi42
reviewed
Jan 21, 2024
@Rangi42 Thanks, I implemented your suggestions. Did I understand them correctly? |
Should pokeyellow/engine/menus/main_menu.asm Lines 278 to 288 in abc3475
|
|
Thank you, that's an elegant solution! ^^ |
dannye
reviewed
Jun 19, 2024
@dannye Done, thanks. |
Rangi42
approved these changes
Jun 22, 2024
vulcandth
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original names for the routines come from these commits: 6faafde and 4571f81. They are a bit confusing since Yellow doesn't have an RTC.
This PR also syncs pokeyellow with pokegold and pokecrystal a bit.