Labeling remaining wram addresses #439
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
what about |
I have a vendetta against them. |
I'm saving those for you to do. |
|
Superseded by #454. (Which could use review/comments based on this though!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the start of labeling the remaining wram addresses.. I'll be working on this in the next few days. Feel free to review as I work.
Just gonna toss all these misc flag constants in wram_constants.asm for now. We can sort them elsewhere later if it makes sense later.
Also, instead of trying to come up with a single wram label for an address whose bits are used for different things... I'm going to opt to just specify multiple labels for the same address.