Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build on NixOS and add instructions to INSTALL.md #1999

Merged
merged 2 commits into from
Jun 20, 2024

Conversation

leo60228
Copy link
Contributor

Description

This fixes a build error on NixOS caused by bash not being at /bin/bash, and adds instructions for building on NixOS to INSTALL.md. It does not include instructions for installing devkitARM, as devkitARM cannot be installed on NixOS without hacks that would almost certainly not be considered supported, but make modern works with the distribution's arm-none-eabi toolchain.

Also see pret/agbcc#70.

Discord contact info

leo60228

Copy link
Collaborator

@mrgriffin mrgriffin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh my god, YES! No more make SHELL='bash -o pipefail' for me 🎉

@mrgriffin mrgriffin merged commit 366f8b3 into pret:master Jun 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants