Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Adapter: Digital Matter #5617

Merged
merged 4 commits into from
Oct 8, 2024
Merged

New Adapter: Digital Matter #5617

merged 4 commits into from
Oct 8, 2024

Conversation

digital-matter
Copy link
Contributor

🏷 Type of documentation

  • new bid adapter

📋 Checklist

Copy link

netlify bot commented Sep 24, 2024

Deploy Preview for prebid-docs-preview ready!

Name Link
🔨 Latest commit 1b8535d
🔍 Latest deploy log https://app.netlify.com/sites/prebid-docs-preview/deploys/6705372b529f580008ca549e
😎 Deploy Preview https://deploy-preview-5617--prebid-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@digital-matter
Copy link
Contributor Author

We would appreciate if this could be reviewed and merged as we already have our adapter released with 9.15 version. Our clients can't include our adapter when building adapter through https://docs.prebid.org/dev-docs/bidders.html. Many thanks in advance!

Copy link
Contributor

@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're missing all of the metadata that publishers want to have about bid adapters. See https://docs.prebid.org/dev-docs/bidder-adaptor.html#submitting-your-adapter

tcfeu_supported: true/false
dsa_supported: true/false
gvl_id: none
usp_supported: true/false
coppa_supported: true/false
gpp_sids: tcfeu, tcfca, usnat, usstate_all, usp
schain_supported: true/false
dchain_supported: true/false
userId: (list of supported vendors)
media_types: banner, video, native
safeframes_ok: true/false
deals_supported: true/false
floors_supported: true/false
fpd_supported: true/false
pbjs: true/false
pbs: true/false
prebid_member: true/false
multiformat_supported: will-bid-on-any, will-bid-on-one, will-not-bid
ortb_blocking_supported: true/partial/false
privacy_sandbox: no or comma separated list of paapi, topics

@digital-matter digital-matter marked this pull request as draft October 8, 2024 08:12
Copy link
Contributor Author

@digital-matter digital-matter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bretg Updated doc with the missing metadata that publishers want to have about bid adapters

@digital-matter digital-matter marked this pull request as ready for review October 8, 2024 08:16
couple of the metadata fields should be 'none' instead of 'false'. Fixed. Also fixed copy-paste error with company name.
@bretg bretg added LGTM and removed needs work labels Oct 8, 2024
@bretg bretg merged commit ddcc3cd into prebid:master Oct 8, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants