Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

useBaseGvlid added to aliasBidder #5601

Merged
merged 3 commits into from
Oct 11, 2024
Merged

useBaseGvlid added to aliasBidder #5601

merged 3 commits into from
Oct 11, 2024

Conversation

mkomorski
Copy link
Collaborator

@mkomorski mkomorski commented Sep 17, 2024

🏷 Type of documentation

  • new bid adapter
  • update bid adapter
  • new feature
  • text edit only (wording, typos)
  • bugfix (code examples)
  • new examples

📋 Checklist

Copy link

netlify bot commented Sep 17, 2024

Deploy Preview for prebid-docs-preview ready!

Name Link
🔨 Latest commit 7983f78
🔍 Latest deploy log https://app.netlify.com/sites/prebid-docs-preview/deploys/67096675426b9c000854acb8
😎 Deploy Preview https://deploy-preview-5601--prebid-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@lpagnypubstack lpagnypubstack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m new member of the documentation task force, so I might be mistaken, but could you please clarify:

  • Is this feature associated with an existing PR that hasn’t been merged yet?
  • Should we also update the example with “useBaseGvlid” in row 39?

Thanks :)

Comment on lines 28 to 31
| Option Parameter | Type | Description |
|------------|---------|---------------------------------|
| gvlid | integer | IAB Global Vendor List ID for this alias for use with the [TCF control module](/dev-docs/modules/tcfControl.html). |
| useBaseGvlid | boolean | Flag determining if the GVL ID of the original adapter should be re-used |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mkomorski could you add a scope column, which indicates which parameters are required or optional? I guess @ChrisHuie went through this with you yesterday 😊 , just wanted to put it here for the record.

Thanks to @lpagnypubstack for pointing this out 🙏

@bretg bretg merged commit 31dc630 into master Oct 11, 2024
5 checks passed
@bretg bretg deleted the mkomorski/useBaseGvlid branch October 11, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants