Added iOS Prebid Plugin Renderer #5580
Conversation
✅ Deploy Preview for prebid-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| In addition to this documentation you have samples on hand which can be get from the Prebid Mobile SDK repository: | ||
|
|
||
| * [PrebidMobilePluginRenderer](https://github.com/prebid/prebid-mobile-ios/blob/master/PrebidMobile/PrebidMobileRendering/PluginRenderer/PrebidMobilePluginRenderer.swift) | ||
| * [PluginEventDelegate](https://github.com/prebid/prebid-mobile-ios/blob/master/PrebidMobile/PrebidMobileRendering/PluginRenderer/PluginEventListener.swift) |
There was a problem hiding this comment.
I see there that you have a file name as PluginEventListener.swift even if the implementation refers as PluginEventDelegate.
I think it should be updated to PluginEventDelegate.swift
There was a problem hiding this comment.
I will create a PR on the prebid-mobile-ios repository
There was a problem hiding this comment.
@Richard-DEPIERRE @jsligh the PR is actually this one
prebid/prebid-mobile-ios#1046
| @@ -174,7 +174,7 @@ public class SampleCustomRenderer: NSObject, PrebidMobilePluginRenderer { | |||
| In addition to this documentation you have samples on hand which can be get from the Prebid Mobile SDK repository: | |||
|
|
|||
| * [PrebidMobilePluginRenderer](https://github.com/prebid/prebid-mobile-ios/blob/master/PrebidMobile/PrebidMobileRendering/PluginRenderer/PrebidMobilePluginRenderer.swift) | |||
| * [PluginEventDelegate](https://github.com/prebid/prebid-mobile-ios/blob/master/PrebidMobile/PrebidMobileRendering/PluginRenderer/PluginEventListener.swift) | |||
| * [PluginEventDelegate](https://github.com/prebid/prebid-mobile-ios/blob/master/PrebidMobile/PrebidMobileRendering/PluginRenderer/PluginEventDelegate.swift) | |||
There was a problem hiding this comment.
PluginEventDelegate does not exist on master.
Current class name is still PluginEventListener
An update must to be added to prebid ios sdk
There was a problem hiding this comment.
Ok, PR opened, this is not a block
prebid/prebid-mobile-ios#1046
| required init(rootController: AdapterViewController) { | ||
| super.init() | ||
| self.rootController = rootController | ||
| Prebid.registerPluginRenderer(sampleCustomRenderer) |
There was a problem hiding this comment.
Does it make sense to register the plugin during the application launch step right after the Prebid SDK initialization? In this case, publishers will not have to register the plugin in each needed place in the app.
|
|
||
| | Company | Documentation | | ||
| |-------|-----------------------------------------------------------------------------------------------| | ||
| <!-- | Teads | [Teads Plugin Renderer Docs](https://support.teads.tv/support/solutions/articles/36000459747) | --> |
There was a problem hiding this comment.
Please review the renderd page. The table is broken on it.
github-richard-depierre
requested review from
YuriyVelichkoPI and
github-lucas-bon
🏷 Type of documentation
📋 Checklist