-
Notifications
You must be signed in to change notification settings - Fork 726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Adapter: Connatix #3916
base: master
Are you sure you want to change the base?
New Adapter: Connatix #3916
Conversation
New Adapter: Connatix
Code coverage summaryNote:
connatixRefer here for heat map coverage report
|
Code coverage summaryNote:
connatixRefer here for heat map coverage report
|
Fix content type header
Code coverage summaryNote:
connatixRefer here for heat map coverage report
|
include ipv6 in ip validation and add headers
Code coverage summaryNote:
connatixRefer here for heat map coverage report
|
endpoint: "https://capi.connatix.com/rtb/ortb" | ||
maintainer: | ||
email: "[email protected]" | ||
gvlVendorID: 143 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"143": {
"id": 143,
"name": "Connatix Native Exchange Inc.",
"purposes": [1, 2],
"legIntPurposes": [],
"flexiblePurposes": [],
"specialPurposes": [3],
"features": [3],
"specialFeatures": [1],
"cookieMaxAgeSeconds": 2600000,
"usesCookies": true,
"cookieRefresh": true,
"usesNonCookieAccess": true,
"dataRetention": {
"purposes": {
"2": 30
},
"specialPurposes": {
"3": 90
}
},
"urls": [
{
"langId": "en",
"privacy": "https://connatix.com/privacy-policy/",
"legIntClaim": "https://connatix.com/privacy-policy/"
}
],
"dataDeclaration": [1, 3, 8, 11],
"deviceStorageDisclosureUrl": "https://connatix.com/iab-tcf-disclosure.json"
},
```
verified
@@ -0,0 +1,20 @@ | |||
endpoint: "https://capi.connatix.com/rtb/ortb" | |||
maintainer: | |||
email: "[email protected]" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
send email for verification, please respond
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@patrickszeleczki Please add more JSON tests (Check which lines of code are not covered by tests). We usually approve PRs when the test coverage is more than 85%. |
Code coverage summaryNote:
connatixRefer here for heat map coverage report
|
improve test coverage
Code coverage summaryNote:
connatixRefer here for heat map coverage report
|
userSync: | ||
iframe: | ||
url: "https://capi.connatix.com/us/pixel?pId=53&gdpr={{.GDPR}}&gdpr_consent={{.GDPRConsent}}&us_privacy={{.USPrivacy}}&callback={{.RedirectURL}}" | ||
userMacro: "[UID]" | ||
redirect: | ||
url: "https://capi.connatix.com/us/pixel?pId=52&gdpr={{.GDPR}}&gdpr_consent={{.GDPRConsent}}&us_privacy={{.USPrivacy}}&callback={{.RedirectURL}}" | ||
userMacro: "[UID]" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs: prebid/prebid.github.io#5595