Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Adapter: Connatix #3916

Open
wants to merge 22 commits into
base: master
Choose a base branch
from
Open

New Adapter: Connatix #3916

wants to merge 22 commits into from

Conversation

patrickszeleczki
Copy link

Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 08242be

connatix

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/connatix/connatix.go:23:	Builder			80.0%
github.com/prebid/prebid-server/v2/adapters/connatix/connatix.go:35:	MakeRequests		66.7%
github.com/prebid/prebid-server/v2/adapters/connatix/connatix.go:81:	MakeBids		80.0%
github.com/prebid/prebid-server/v2/adapters/connatix/connatix.go:121:	validateAndBuildImpExt	66.7%
github.com/prebid/prebid-server/v2/adapters/connatix/connatix.go:134:	validateConnatixExt	66.7%
github.com/prebid/prebid-server/v2/adapters/connatix/connatix.go:143:	splitRequests		90.9%
github.com/prebid/prebid-server/v2/adapters/connatix/connatix.go:185:	buildRequestImp		66.7%
github.com/prebid/prebid-server/v2/adapters/connatix/connatix.go:233:	buildDisplayManageVer	55.6%
github.com/prebid/prebid-server/v2/adapters/connatix/connatix.go:251:	getBidType		100.0%
total:									(statements)		74.5%

Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 55ec262

connatix

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/connatix/connatix.go:23:	Builder			80.0%
github.com/prebid/prebid-server/v2/adapters/connatix/connatix.go:35:	MakeRequests		66.7%
github.com/prebid/prebid-server/v2/adapters/connatix/connatix.go:81:	MakeBids		80.0%
github.com/prebid/prebid-server/v2/adapters/connatix/connatix.go:121:	validateAndBuildImpExt	66.7%
github.com/prebid/prebid-server/v2/adapters/connatix/connatix.go:134:	validateConnatixExt	66.7%
github.com/prebid/prebid-server/v2/adapters/connatix/connatix.go:143:	splitRequests		90.9%
github.com/prebid/prebid-server/v2/adapters/connatix/connatix.go:185:	buildRequestImp		66.7%
github.com/prebid/prebid-server/v2/adapters/connatix/connatix.go:233:	buildDisplayManageVer	55.6%
github.com/prebid/prebid-server/v2/adapters/connatix/connatix.go:251:	getBidType		100.0%
total:									(statements)		74.5%

Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 28ed966

connatix

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/connatix/connatix.go:23:	Builder			80.0%
github.com/prebid/prebid-server/v2/adapters/connatix/connatix.go:35:	MakeRequests		66.7%
github.com/prebid/prebid-server/v2/adapters/connatix/connatix.go:81:	MakeBids		80.0%
github.com/prebid/prebid-server/v2/adapters/connatix/connatix.go:121:	validateAndBuildImpExt	66.7%
github.com/prebid/prebid-server/v2/adapters/connatix/connatix.go:134:	validateConnatixExt	66.7%
github.com/prebid/prebid-server/v2/adapters/connatix/connatix.go:143:	splitRequests		90.9%
github.com/prebid/prebid-server/v2/adapters/connatix/connatix.go:185:	buildRequestImp		66.7%
github.com/prebid/prebid-server/v2/adapters/connatix/connatix.go:233:	buildDisplayManageVer	55.6%
github.com/prebid/prebid-server/v2/adapters/connatix/connatix.go:251:	getBidType		100.0%
total:									(statements)		74.5%

Copy link

github-actions bot commented Oct 2, 2024

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 4c7a620

connatix

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/connatix/connatix.go:23:	Builder			80.0%
github.com/prebid/prebid-server/v2/adapters/connatix/connatix.go:35:	MakeRequests		66.7%
github.com/prebid/prebid-server/v2/adapters/connatix/connatix.go:81:	MakeBids		80.0%
github.com/prebid/prebid-server/v2/adapters/connatix/connatix.go:121:	validateAndBuildImpExt	66.7%
github.com/prebid/prebid-server/v2/adapters/connatix/connatix.go:134:	validateConnatixExt	66.7%
github.com/prebid/prebid-server/v2/adapters/connatix/connatix.go:143:	splitRequests		92.9%
github.com/prebid/prebid-server/v2/adapters/connatix/connatix.go:197:	buildRequestImp		66.7%
github.com/prebid/prebid-server/v2/adapters/connatix/connatix.go:245:	buildDisplayManageVer	55.6%
github.com/prebid/prebid-server/v2/adapters/connatix/connatix.go:263:	getBidType		100.0%
total:									(statements)		75.9%

endpoint: "https://capi.connatix.com/rtb/ortb"
maintainer:
email: "[email protected]"
gvlVendorID: 143
Copy link
Collaborator

@przemkaczmarek przemkaczmarek Oct 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"143": {
      "id": 143,
      "name": "Connatix Native Exchange Inc.",
      "purposes": [1, 2],
      "legIntPurposes": [],
      "flexiblePurposes": [],
      "specialPurposes": [3],
      "features": [3],
      "specialFeatures": [1],
      "cookieMaxAgeSeconds": 2600000,
      "usesCookies": true,
      "cookieRefresh": true,
      "usesNonCookieAccess": true,
      "dataRetention": {
        "purposes": {
          "2": 30
        },
        "specialPurposes": {
          "3": 90
        }
      },
      "urls": [
        {
          "langId": "en",
          "privacy": "https://connatix.com/privacy-policy/",
          "legIntClaim": "https://connatix.com/privacy-policy/"
        }
      ],
      "dataDeclaration": [1, 3, 8, 11],
      "deviceStorageDisclosureUrl": "https://connatix.com/iab-tcf-disclosure.json"
    },
    ```
    
verified
    

@@ -0,0 +1,20 @@
endpoint: "https://capi.connatix.com/rtb/ortb"
maintainer:
email: "[email protected]"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

send email for verification, please respond

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirmed:
image

@przemkaczmarek
Copy link
Collaborator

@patrickszeleczki Please add more JSON tests (Check which lines of code are not covered by tests). We usually approve PRs when the test coverage is more than 85%.

Copy link

github-actions bot commented Oct 3, 2024

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 15bdaa2

connatix

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/connatix/connatix.go:23:	Builder			80.0%
github.com/prebid/prebid-server/v2/adapters/connatix/connatix.go:35:	MakeRequests		66.7%
github.com/prebid/prebid-server/v2/adapters/connatix/connatix.go:81:	MakeBids		80.0%
github.com/prebid/prebid-server/v2/adapters/connatix/connatix.go:121:	validateAndBuildImpExt	66.7%
github.com/prebid/prebid-server/v2/adapters/connatix/connatix.go:134:	validateConnatixExt	66.7%
github.com/prebid/prebid-server/v2/adapters/connatix/connatix.go:143:	splitRequests		92.9%
github.com/prebid/prebid-server/v2/adapters/connatix/connatix.go:197:	buildRequestImp		66.7%
github.com/prebid/prebid-server/v2/adapters/connatix/connatix.go:245:	buildDisplayManageVer	55.6%
github.com/prebid/prebid-server/v2/adapters/connatix/connatix.go:263:	getBidType		100.0%
total:									(statements)		75.9%

Copy link

github-actions bot commented Oct 3, 2024

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 9d79042

connatix

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/connatix/connatix.go:23:	Builder			80.0%
github.com/prebid/prebid-server/v2/adapters/connatix/connatix.go:35:	MakeRequests		100.0%
github.com/prebid/prebid-server/v2/adapters/connatix/connatix.go:81:	MakeBids		80.0%
github.com/prebid/prebid-server/v2/adapters/connatix/connatix.go:121:	validateAndBuildImpExt	83.3%
github.com/prebid/prebid-server/v2/adapters/connatix/connatix.go:134:	validateConnatixExt	100.0%
github.com/prebid/prebid-server/v2/adapters/connatix/connatix.go:143:	splitRequests		92.9%
github.com/prebid/prebid-server/v2/adapters/connatix/connatix.go:197:	buildRequestImp		90.5%
github.com/prebid/prebid-server/v2/adapters/connatix/connatix.go:245:	buildDisplayManageVer	55.6%
github.com/prebid/prebid-server/v2/adapters/connatix/connatix.go:263:	getBidType		100.0%
total:									(statements)		87.9%

Comment on lines +14 to +20
userSync:
iframe:
url: "https://capi.connatix.com/us/pixel?pId=53&gdpr={{.GDPR}}&gdpr_consent={{.GDPRConsent}}&us_privacy={{.USPrivacy}}&callback={{.RedirectURL}}"
userMacro: "[UID]"
redirect:
url: "https://capi.connatix.com/us/pixel?pId=52&gdpr={{.GDPR}}&gdpr_consent={{.GDPRConsent}}&us_privacy={{.USPrivacy}}&callback={{.RedirectURL}}"
userMacro: "[UID]"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only iframe works:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants