Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smarthub: renaming Smarthub to Attekmi #12432

Merged

Conversation

SmartHubSolutions
Copy link
Contributor

Type of change

  • Other

Description of change

We change adapter name from Smarthub to Attekmi but keep biddercode 'smarthub'

Docs PR prebid/prebid.github.io#5699

@ChrisHuie ChrisHuie self-requested a review November 12, 2024 12:49
@ChrisHuie ChrisHuie self-assigned this Nov 12, 2024
jdpmedia: 'https://jdpmedia-prebid.attekmi.com/pbjs',
tredio: 'https://tredio-prebid.attekmi.com/pbjs',
felixads: 'https://felixads-prebid.attekmi.com/pbjs',
vimayx: 'https://vimayx-prebid.attekmi.com/pbjs',
};
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't you add Attekmi as another alias and add docs for it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are currently rebranding the entire company, and changed Smarthub to Attekmi. We also leave simultaneous support for old *-prebid.smart-hub.io endpoints and new *-prebid.attekmi.con endpoints for current connections.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't you add support for that alias?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you meant to add an alias for future changes, then I understand you and I added the Attekmi alias.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

jdpmedia: 'https://jdpmedia-prebid.attekmi.com/pbjs',
tredio: 'https://tredio-prebid.attekmi.com/pbjs',
felixads: 'https://felixads-prebid.attekmi.com/pbjs',
vimayx: 'https://vimayx-prebid.attekmi.com/pbjs',
};
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@patmmccann patmmccann merged commit b941544 into prebid:master Nov 14, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants