-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Smarthub: renaming Smarthub to Attekmi #12432
Smarthub: renaming Smarthub to Attekmi #12432
Conversation
jdpmedia: 'https://jdpmedia-prebid.attekmi.com/pbjs', | ||
tredio: 'https://tredio-prebid.attekmi.com/pbjs', | ||
felixads: 'https://felixads-prebid.attekmi.com/pbjs', | ||
vimayx: 'https://vimayx-prebid.attekmi.com/pbjs', | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why don't you add Attekmi as another alias and add docs for it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are currently rebranding the entire company, and changed Smarthub to Attekmi. We also leave simultaneous support for old *-prebid.smart-hub.io endpoints and new *-prebid.attekmi.con endpoints for current connections.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why don't you add support for that alias?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you meant to add an alias for future changes, then I understand you and I added the Attekmi alias.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
jdpmedia: 'https://jdpmedia-prebid.attekmi.com/pbjs', | ||
tredio: 'https://tredio-prebid.attekmi.com/pbjs', | ||
felixads: 'https://felixads-prebid.attekmi.com/pbjs', | ||
vimayx: 'https://vimayx-prebid.attekmi.com/pbjs', | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
Type of change
Description of change
We change adapter name from Smarthub to Attekmi but keep biddercode 'smarthub'
Docs PR prebid/prebid.github.io#5699