-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pubxaiAnalyticsAdapter : collect rejected and nobid cases' data in a better way. #12263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
send BidRejected Events to capture floored bids
Add extraData to the body of beacon data for analytics adapter
…ng-of-invalid-bids Pub 2941 fixing missing logging of invalid bids
ChrisHuie
changed the title
pubxaiAnalyticsAdapter: Bugfix - Collect rejected and nobid cases' data in a better way.
pubxaiAnalyticsAdapter : collect rejected and nobid cases' data in a better way.
Sep 23, 2024
ChrisHuie
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Invalid bids are mapped to bidtype 1. Timed-out bids are mapped to bidtype 3. If any auction contains only bidtypes 1 or 3, it is now sent to pubx.
Additional tests were added to confirm that auctions with timed out bids or invalid bids.