Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update omsBidAdapter.js: allow aliases #12048

Merged
merged 1 commit into from
Jul 29, 2024
Merged

Conversation

patmmccann
Copy link
Collaborator

fixes #12047

Type of change

  • Bugfix

  • Feature

  • New bidder adapter

  • Updated bidder adapter

  • Code style update (formatting, local variables)

  • Refactoring (no functional changes, no api changes)

  • Build related changes

  • CI related changes

  • Does this change affect user-facing APIs or examples documented on http://prebid.org?

  • Other

Description of change

Other information

Copy link

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

@patmmccann
Copy link
Collaborator Author

@andyblackwell fyi

Copy link
Contributor

@andyblackwell andyblackwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dunno if my review counts, but yep this will fix 👍

@patmmccann patmmccann self-assigned this Jul 29, 2024
@patmmccann patmmccann merged commit fa3f86a into master Jul 29, 2024
5 of 6 checks passed
@patmmccann patmmccann deleted the patmmccann-patch-14 branch July 29, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

oms / brightcom's bid adapters prevent any aliases in isBidRequestValid()
2 participants