-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Calculate multiline text cell width and add nowrap option #50
base: master
Are you sure you want to change the base?
Conversation
So far this looks good. Can you please add a couple of specs to ensure that the behavior with and without nowrap will continue to work correctly? Thanks! |
@pointlessone is there any reason this can't be merged? (tagging you because you seem to be the person who commits most here). I really need this functionality for my project. I can use a fork, but I'd rather help (if needed) test this fix and get it in the mainline. |
@andyjeffries When you look at the code of the pull request, you can see that there are no tests and no documentation. So once someone has the time to add those and make sure the current behaviour still works as before, the maintainers can have another look at it. |
Thanks @gettalong, I don't know the codebase but I'm trying to get in to this. I've just checked current master though and it fails for me:
So I'll ignore that one spec failure and work on making sure the other current specs pass and new ones are added for this feature. |
Based almost entirely on: prawnpdf#50 Implements the wrapping, adds no more failures (than the current master fails on 3.0.4 anyway), but adds new tests and documentation.
No description provided.