Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add warning if crud transactions are not completed #172

Merged
merged 7 commits into from
Oct 2, 2024

Conversation

mugikhan
Copy link
Contributor

@mugikhan mugikhan commented Sep 25, 2024

Description

This is a backport of a feature added to the powersync js SDK. It ensures that there is a warning displayed when the same CrudEntry is processed by the upload loop. See this PR in the JS SDK for a more detailed explanation.

Work done

  • Display warning if crud transactions are in queue to be uploaded

@mugikhan mugikhan marked this pull request as ready for review September 26, 2024 07:56
stevensJourney
stevensJourney previously approved these changes Oct 1, 2024
Copy link
Contributor

@stevensJourney stevensJourney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

stevensJourney
stevensJourney previously approved these changes Oct 1, 2024
@mugikhan mugikhan merged commit f17ea6f into main Oct 2, 2024
7 checks passed
@mugikhan mugikhan deleted the feat/crud-transactions-warning branch October 2, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants