[Workflow] Update Packages Deploy #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[1/4] Resolving packages... [2/4] Fetching packages... [3/4] Linking dependencies... [4/4] Building fresh packages... Done in 26.46s. is recommened in changeset docs.
rkistner
reviewed
Oct 12, 2023
| @@ -35,15 +35,17 @@ export interface WatchOnChangeEvent { | |||
| changedTables: string[]; | |||
| } | |||
|
|
|||
| export interface PowerSyncDBListener extends StreamingSyncImplementationListener {} | |||
|
|
|||
| const POWERSYNC_TABLE_MATCH = /(^ps_data__|^ps_local__)/; | |||
There was a problem hiding this comment.
This should be /(^ps_data__|^ps_data_local__)/
There was a problem hiding this comment.
🙏 Good catch. Thanks for pointing that out.
rkistner
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the package deploy workflow process.
Versioning
Package versioning tools like Lerna lerna/lerna#2342 and Changesets changesets/changesets#818 have open issues when working with Git submodules.
Submodules in this repo help with development and testing when using included testing Applications. Development packages are supported when making changes that include submodule packages, but production packages require the submodule packages to be versioned, tagged and published from their own repo before updating local packages here.
Versioning Instructions are added to the readme.
Fixes
This PR contains a fix to allow watched queries to reload when
local_onlytables are updated.