Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Concurrent DB Connections and Transactions #7

Merged
merged 15 commits into from
Oct 30, 2023

Conversation

stevensJourney
Copy link
Collaborator

@stevensJourney stevensJourney commented Oct 11, 2023

This PR updates SDK packages to use concurrent SQLite connections and transactions from powersync-ja/react-native-quick-sqlite#2

Some API changes are made in this PR:

  • Removal of synchronous DB operations in transactions: execute, commit, rollback are now async functions. executeAsync, commitAsync and rollbackAsync have been removed.
  • Transaction contexts now have get, getAll and getOptional helpers.
  • Added a default lock timeout of 2 minutes to aide with potential recursive lock/transaction requests.

Testing:
This has been tested with the Supabase Todo list app. Automated tests are currently a work in progress on the unit_tests branch.

TODO:

  • Bump package versions.

@stevensJourney stevensJourney marked this pull request as ready for review October 30, 2023 11:35
@stevensJourney stevensJourney merged commit b612362 into main Oct 30, 2023
1 check passed
@stevensJourney stevensJourney deleted the feature/concurrent-transactions branch October 30, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants