Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move to js monorepo #47

Merged
merged 9 commits into from
Feb 8, 2024
Merged

Conversation

DominicGBauer
Copy link
Collaborator

Description

Move toward a JS monorepo with Pnpm

Work Done

  • Moved to pnpm
  • Included react native project
  • Changed github actions to use pnpm
  • Packages now use workspace deps for local packages that they are dependent on (not sure if this is correct or you want to keep them set?)

@DominicGBauer DominicGBauer self-assigned this Feb 7, 2024
Copy link
Collaborator

@stevensJourney stevensJourney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments. The workspace package version dependencies should be fine to use.

Some notes from testing the demo app:
It seems like some of the Android config which enabled streamed queries is no longer applied. When testing on a device the connection did not resolve.

iOS seems to work fine 😄

.github/workflows/deploy-docs.yaml Show resolved Hide resolved
.github/workflows/dev-packages.yaml Show resolved Hide resolved
.github/workflows/dev-packages.yaml Show resolved Hide resolved
demos/supabase-todo-list-react-native/.envrc Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
Copy link
Collaborator

@stevensJourney stevensJourney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work!

@DominicGBauer DominicGBauer merged commit ce93779 into main Feb 8, 2024
1 check passed
@DominicGBauer DominicGBauer deleted the chore/move-to-js-monorepo branch February 8, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants