Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed angular demo app issues related to newer versions of web SDK and wa-sqlite. #442

Merged
merged 7 commits into from
Dec 13, 2024

Conversation

Chriztiaan
Copy link
Contributor

@Chriztiaan Chriztiaan commented Dec 12, 2024

We identified an issue with the Angular demo app when running on versions of “@journeyapps/wa-sqlite” newer than “0.4.2” and “@powersync/web” newer than “1.10.2”. The problem appears to stem from the newer wa-sqlite code not interacting correctly with Angular’s Zone.js dependecy.

As a workaround, you can copy the worker assets directly into the project and configure them at instantiation, similar to the approach used in the react-native-web demo. This approach resolves the issue. The README and code have been updated accordingly. Copying happens automatically as part of the serve/build steps in the demo.

Copy link

changeset-bot bot commented Dec 12, 2024

⚠️ No Changeset found

Latest commit: e7eb08f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Chriztiaan Chriztiaan marked this pull request as ready for review December 12, 2024 09:13
DominicGBauer
DominicGBauer previously approved these changes Dec 12, 2024
@Chriztiaan Chriztiaan merged commit efff686 into main Dec 13, 2024
6 checks passed
@Chriztiaan Chriztiaan deleted the fix/angular-start-async-bug branch December 13, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants