Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isolated Demo Tests #234

Merged
merged 36 commits into from
Jul 29, 2024
Merged

Isolated Demo Tests #234

merged 36 commits into from
Jul 29, 2024

Conversation

stevensJourney
Copy link
Collaborator

@stevensJourney stevensJourney commented Jul 22, 2024

Overview

We've noticed that demo sometimes behave differently outside the monorepo. This seems to be due to our monorepo package hoisting configuration.

This adds an automated test which will move the demos to standalone test projects for testing.

The current workspace packages are published to a locally hosted NPM registry. These packages are used when installing the demo's dependencies.

This tests if the demo's install script and test:build script. A test:build script has been added to some demos which specifies the test criteria for building the demo.

Only some of the Demos currently have functional build tests. Other demos can be added in future PRs.

The action shows a summary of all demos which were tested. A warning is shown if the demo does not have a test:build script.

image

Copy link

changeset-bot bot commented Jul 22, 2024

⚠️ No Changeset found

Latest commit: d1dffad

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@stevensJourney stevensJourney marked this pull request as ready for review July 29, 2024 08:44
Chriztiaan
Chriztiaan previously approved these changes Jul 29, 2024
rkistner
rkistner previously approved these changes Jul 29, 2024
@stevensJourney stevensJourney dismissed stale reviews from rkistner and Chriztiaan via d1dffad July 29, 2024 11:04
@stevensJourney stevensJourney merged commit 42a661e into main Jul 29, 2024
4 checks passed
@stevensJourney stevensJourney deleted the feat/isolated-tests branch July 29, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants