[Feature] @journeyapps/powersync-attachments library
#20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manrich121
changed the title
@journeyapps/powersync-attachments library@journeyapps/powersync-attachments library
1 task
…-native-sdk into lib/attachments
…tachmentRecord` async
stevensJourney
previously approved these changes
Nov 2, 2023
rkistner
approved these changes
Nov 2, 2023
Comment on lines
+15
to
+19
| writeFile( | ||
| fileURI: string, | ||
| base64Data: string, | ||
| options?: { encoding?: EncodingType } | ||
| ): Promise<void>; |
There was a problem hiding this comment.
For a future version, it may be better to just take an ArrayBuffer (or Uint8Array) as parameter, and do the base64 encoding in the adapter implementation.
Also, not directly relevant here, but the demo implementation defaults to UTF8 decoding, despite the parameter being called base64Data.
Comment on lines
+21
to
+24
| readFile( | ||
| fileURI: string, | ||
| options?: { encoding?: EncodingType; mediaType?: string } | ||
| ): Promise<ArrayBuffer>; |
There was a problem hiding this comment.
Is encoding relevant when an ArrayBuffer is returned either way?
| Base64 = "base64", | ||
| } | ||
|
|
||
| export interface StorageAdapter { |
There was a problem hiding this comment.
It would help to have documentation for the methods and parameters here - especially the difference between file URI and path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PowerSync library to manage attachments in TypeScript and React Native apps