better locks for CRUD uploads

powersync-ja · Nov 20, 2023 · 8ff6325 · 8ff6325
1 parent 3d81a1f
commit 8ff6325
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 13 deletions.
diff --git a/.changeset/dull-radios-relate.md b/.changeset/dull-radios-relate.md
@@ -0,0 +1,5 @@
+---
+'@journeyapps/powersync-sdk-common': patch
+---
+
+Added better locking for CRUD uploads
diff --git a/packages/powersync-sdk-common/src/client/sync/stream/AbstractStreamingSyncImplementation.ts b/packages/powersync-sdk-common/src/client/sync/stream/AbstractStreamingSyncImplementation.ts
@@ -89,21 +89,26 @@ export abstract class AbstractStreamingSyncImplementation extends BaseObserver<S
   }
 
   protected async _uploadAllCrud(): Promise<void> {
-    this.isUploadingCrud = true;
-    while (true) {
-      try {
-        const done = await this.uploadCrudBatch();
-        if (done) {
-          this.isUploadingCrud = false;
-          break;
+    return this.obtainLock({
+      type: LockType.CRUD,
+      callback: async () => {
+        this.isUploadingCrud = true;
+        while (true) {
+          try {
+            const done = await this.uploadCrudBatch();
+            if (done) {
+              this.isUploadingCrud = false;
+              break;
+            }
+          } catch (ex) {
+            this.updateSyncStatus(false);
+            await this.delayRetry();
+            this.isUploadingCrud = false;
+            break;
+          }
         }
-      } catch (ex) {
-        this.updateSyncStatus(false);
-        await this.delayRetry();
-        this.isUploadingCrud = false;
-        break;
       }
-    }
+    });
   }
 
   protected async uploadCrudBatch(): Promise<boolean> {