Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display better error message for missing credentials #27

Merged
merged 2 commits into from
Sep 19, 2023

Conversation

stephenagreer
Copy link
Contributor

irb(main):002:0> OmniAuth::Strategies::NitroId.new({}).client
Traceback (most recent call last):
        5: from bin/console:8:in `<main>'
        4: from (irb):1
        3: from (irb):2:in `rescue in irb_binding'
        2: from /Users/greersa/Workspace/omniauth-nitro-id/lib/omniauth/strategies/base_strategy.rb:22:in `client'
        1: from /Users/greersa/Workspace/omniauth-nitro-id/lib/omniauth/strategies/base_strategy.rb:25:in `rescue in client'
OmniAuth::Strategies::BaseStrategy::ClientCredentialsError (NitroId client credentials not found. Please check your environment.)

@stephenagreer stephenagreer requested a review from a team as a code owner September 19, 2023 19:57
Copy link
Contributor

@web-kat web-kat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@stephenagreer stephenagreer merged commit be46d05 into main Sep 19, 2023
6 checks passed
@stephenagreer stephenagreer deleted the better-client-error branch September 19, 2023 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants