New Console output format (without tputs) #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sidz
commented
Jul 6, 2022
| return sprintf( | ||
| '%d) %s:%d Magic number: %s', | ||
| $index, | ||
| $detection->getFilePath(), |
There was a problem hiding this comment.
Show real path instead of just filename as it is possible to have identical file names but under different namespaces.
There was a problem hiding this comment.
This changes the output format doesnt it ? May be better to wait for a new major version.
There was a problem hiding this comment.
It may take ages to release new major :)
There was a problem hiding this comment.
Agreed but a break in a major version is not great either :(
Merged
sidz
force-pushed
the
rework-console-output
branch
from
4fdeac9 to
4c218d8
Compare
sidz
force-pushed
the
rework-console-output
branch
from
4c218d8 to
cc07c4d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework Console output in order to get rid of
tpus.That is how it looks like:
Fixes an issue #153