bounding box check using min/max, not scaled value in [0,1] #634
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a LAZ file being rejected due to the bounding box check. I did verified the bounding box using
lasinfo
which shows no point is outside bounding box.The bounding box check code did not compare
xyz
to the originalmin/max
, instead it compared scaledux/uy/uz
to[0,1]
. Due to the double decimal precision, a tiny error could be introduced and makeux>1
causing converter reject the LAZ file. Even the x is inside the original min/max, and no error reported bylasinfo
.It would make sense to check the bounding box to use
min/max
to avoid any decimal precision error introduced using the scaled values.