Fix bug where chunks containing exactly 10000 points are lost during indexing #607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petern-annotell
pushed a commit
to petern-annotell/PotreeConverter
that referenced
this pull request
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is most likely the cause behind issue #597
Before this fix, the created octree.bin is 10000 * bits_per_point bytes smaller than it should be according to the point count and bits per point in the created metadata.json. Thus, the resulting potree point cloud contains 10000 points less than the input las file and than what it says in the metadata.json file.
When the indexer builds the hierarchy, this bug caused recursion to stop when encountering a chunk containing exactly 10000 points, neither recursing down into parts of the chunk nor writing the chunk out to the octree.bin file.
Unfortunately I can not publish the las input files that are affected by this bug.