Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repair backup failed (the value of segment_size is greater than 2G) #510

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

hslightdb
Copy link

If the value of segment_size is greater than 2G, the file length will overflow. In this case, the backup will fail.

src/catalog.c Outdated Show resolved Hide resolved
src/pg_probackup.h Show resolved Hide resolved
@hslightdb hslightdb requested review from funny-falcon and removed request for gsmolk and kulaginm October 19, 2022 02:40
@qiuwenhuifx
Copy link

@funny-falcon ,I see this problem still exists, are there any plans to fix this?

@qiuwenhuifx
Copy link

qiuwenhuifx commented Aug 24, 2023

@funny-falcon
INFO: Backup files are synced, time elapsed: 0
INFO: Validating backup RZW6OO
ERROR: Cannot seek block 261889 of "/data00/pgsql/backup/backups/pg_5436/RZW6OO/database/base/16393/16440.1": Invalid argument
ERROR: Data files validation failed
pgsql@n97-16-066:~$ du -sh /data00/pgsql/backup/backups/pg_5436/RZW6OO/database/base/16393/16440.1
2.4G /data00/pgsql/backup/backups/pg_5436/RZW6OO/database/base/16393/16440.1

@funny-falcon
Copy link
Collaborator

Currently there are no plans to fix it, since it quite hard due to backward compatibility issues.

@funny-falcon
Copy link
Collaborator

Ah, I see: your patch is quite capable. Ok, let me think once more.

@qiuwenhuifx
Copy link

@funny-falcon ,It seems n_blocks variable type is int ( file->n_blocks = (int) n_blocks) ,postgrespro has already fixed the (xid 32bit) issue, I think no reason why it can't be fixed!,Thank you very much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants