Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup js-interact server #55

Merged
merged 5 commits into from
Sep 3, 2022
Merged

setup js-interact server #55

merged 5 commits into from
Sep 3, 2022

Conversation

imnotkind
Copy link
Member

@imnotkind imnotkind commented Aug 14, 2022

Type of this PR

Select at least one type

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Bug fix
  • Dependency, Environment, Build related update
  • Documentation
  • Other tiny fix

Describe your changes

js-interact dummy api 서버 코드 작성했습니다.
원래 zero-install 과 typescript관련 에러가 좀 있어서 해결하는데 힘들었었는데 어찌어찌 만지다 보니 해결된 것 같습니다.
빌드 관련해서 추가할만한게 lint나 format하고 cd 정도일듯합니다
간단한 integration test도 포함되어 있습니다만 github ci에는 포함시키지 않은 상태입니다

Issue ticket number and other helpful resource

#52

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • Leave reference about this pull request, if exist (ex. discord message, google docs, etc)
  • If it is a core feature, I have added thorough tests.

Checklist after creating a pull request

  • Mention reviews in discord channel directly

Copy link
Contributor

@happyhappy-jun happyhappy-jun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 폴더 이름하고 모듈이름을 고민해봤는데 ts-interact 로 적는게 좋을꺼 같습니다.
  • dist 는 빌드 아웃 폴더인데, 커밋에서 삭제해주세요
  • 그리고 포크후 생성한 브랜치가 아닌 팀 레포에 브랜치를 만들었는데 다음번엔 포크한 곳에 브랜치 만들어주세요!

js-interact/index.test.ts Outdated Show resolved Hide resolved
js-interact/index.test.ts Outdated Show resolved Hide resolved
js-interact/index.test.ts Outdated Show resolved Hide resolved
js-interact/JsInteract.ts Outdated Show resolved Hide resolved
js-interact/JsInteract.ts Outdated Show resolved Hide resolved
@imnotkind
Copy link
Member Author

혹시 제대로 빌드가 안 되는 상황에 도움이 될까봐 빌드아웃 폴더도 포함하는게 좋을까 했는데, 역시 포함 안 하는게 나으려나요?

Copy link
Contributor

@happyhappy-jun happyhappy-jun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

큰 문제는 없을 꺼 같아 추후에 빌드 파일을 제거 하는 방향으로 가는게 좋을꺼 같습니다. 빌드가 안되면 빌드 문제를 해결하도록 하죠. 일단 다른 작업을 위해 머지하고 다른 PR 에서 해결하도록 하죠

@happyhappy-jun happyhappy-jun merged commit 3352bc1 into main Sep 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants