Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration test for simple-counter #47

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

junsoo37
Copy link
Member

@junsoo37 junsoo37 commented Aug 1, 2022

Type of this PR

Select at least one type

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Bug fix
  • Dependency, Environment, Build related update
  • Documentation
  • Other tiny fix

Describe your changes

simple-counter integration test 구현입니다. near sandbox 환경에서 실행되고 테스트 완료했습니다.
build 스크립트는 병준님 yarn 세팅 PR과 겹치기에, yarn PR에 아래 테스트 명령어가 반영되면 될 것 같습니다.
cargo build --package pdao-near-simple-counter --target wasm32-unknown-unknown --release && cp target/wasm32-unknown-unknown/release/pdao_near_simple_counter.wasm ./out/simple_counter.wasm && cd simple-counter && cargo test --all

Issue ticket number and other helpful resource

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • Leave reference about this pull request, if exist (ex. discord message, google docs, etc)
  • If it is a core feature, I have added thorough tests.

Checklist after creating a pull request

  • Mention reviews in discord channel directly

@junsoo37 junsoo37 self-assigned this Aug 1, 2022
@junsoo37 junsoo37 changed the title Implement integration test for simple-counter Integration test for simple-counter Aug 1, 2022
@junsoo37
Copy link
Member Author

junsoo37 commented Aug 1, 2022

CI에서 테스트시에 sandbox 테스트도 같이 진행되고 sandbox 테스트를 위해서는 본문의 적은 커맨드를 통해 생성되는 out/_.wasm 파일이 필요해서 CI 실패가 되네요.
CI의 테스트를 cargo test가 아닌 이전 명령어까지 포함한 yarn 커맨드 방식으로 변경이 필요하겠군요.

@junsoo37
Copy link
Member Author

junsoo37 commented Aug 1, 2022

이 fix PR에서 판거라 타겟 브랜치를 해당 PR 브랜치로 설정하고 싶은데 불가능하네요. fix PR 머지하고 타겟 브랜치 변경해서 보면 편할 것 같습니다.

@junsoo37 junsoo37 force-pushed the feat/simple-counter/integration-test branch from eb7f719 to 8115040 Compare August 3, 2022 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant