Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed issue 532 #537

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fixed issue 532 #537

wants to merge 1 commit into from

Conversation

pannone
Copy link

@pannone pannone commented Aug 1, 2024

Fixed issue #532

@github-actions github-actions bot added the size/XS Extra Small size issue or PR. label Aug 1, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Welcome! Looks like this is your first pull request.

Hey, thanks for your contribution! Please give us a bit of time to review it. 😄

Copy link

@galaris galaris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This implements the mentioned fix correctly

@mitcdh
Copy link

mitcdh commented Aug 3, 2024

Does this preserve the original distances? Everything appears more spaced out now than compiling with -2.0mm on previous versions.

@ericswpark
Copy link

This doesn't seem like the correct fix, or there might be another bug that was introduced by the update to the LaTeX distributions (i.e. not a complete fix). The new renders add a lot more whitespace with the 2 mm option.

Copy link
Collaborator

@OJFord OJFord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, thanks both; all for sorting it for MacTex 2024 & whatever the full set of newly problematic variants is, but we need to keep it working as-was, both with old/different versions and rendered as similarly as possible in the new.

(Just 'requesting changes' to highlight it and block inadvertent merge.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Extra Small size issue or PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants