Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bumping hono/node-server to support ipv6 #1155

Merged
merged 2 commits into from
Oct 10, 2024

Conversation

sinasab
Copy link
Contributor

@sinasab sinasab commented Oct 10, 2024

See context here: #1146

Upstream change to hono/node-server was included @ honojs/node-server#206

This PR bumps the version of hono/node-server to include the upstream change. I also added a test to ensure ipv6 works, which should help avoid future regressions as well!

@sinasab sinasab mentioned this pull request Oct 10, 2024
See context here: ponder-sh#1146

Upstream change to hono/node-server was included @ honojs/node-server#206

This PR bumps the version of hono/node-server to include the upstream change. I also added a test to ensure ipv6 works, which should help avoid future regressions as well!
@sinasab sinasab force-pushed the sina/bump-hono-node-server branch from 927ceb5 to 6d50581 Compare October 10, 2024 21:07
Copy link
Collaborator

@typedarray typedarray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great work and thanks for the writing the test.

@kyscott18 kyscott18 merged commit 84889e6 into ponder-sh:main Oct 10, 2024
8 checks passed
@sinasab sinasab deleted the sina/bump-hono-node-server branch October 10, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants