Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default font size for code lines #146

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

everdimension
Copy link

@everdimension everdimension commented Oct 25, 2019

This change fixes line cropping that users may experience if they set custom font size in the browser settings


Problem explained in images:

What it looks like now:

Screen Shot 2019-10-25 at 13 42 11

The settings in chrome that I have (and that many other people may have):

Screen Shot 2019-10-25 at 13 42 33

What it looks like after the fix:

Screen Shot 2019-10-25 at 13 44 18

Why this fix is okay for a11y:

I want to emphasize that this is a quick fix that should ideally be temporary. It's best to later change the hardcoded height: 15px values to something that respects the current rem size.

At the same time, this quick fix is a good solution because you no longer see cropped text (which is hard to read by itself) and also if someone wishes to make their text larger, the zoom-in combo command++ still works.

This change fixes line cropping that users may
experience if they set custom font size in the browser settings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant