Expose context to middleware #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows Redis to route our execution to the correct node when running in a Redis Cluster.
A recent upstream change bumped Work to go-redis/v8, which uses a context everywhere. Despite this, the context wasn't available to the middleware, which meant we couldn't pass execution-specific information to the actual handler. This commit effectively moves everything from HandlerFunc to ContextHandlerFunc, passing the context to the middleware and underlying operations.
jpalawaga
force-pushed
the
master
branch
2 times, most recently
from
f35f7cc to
414947a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent upstream change bumped Work to go-redis/v8, which uses a
context everywhere. Despite this, the context wasn't available to the
middleware, which meant we couldn't pass execution-specific
information to the actual handler.
This commit effectively moves everything from HandlerFunc to
ContextHandlerFunc, passing the context to the middleware and
underlying operations.
Note that this is a prerequisite for polytomic/app#816.