changed logic in parse subscription to handle class designation #559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removed old method. oops.
mickeyyawn
requested review from
jbonzo,
mmoghaddam385 and
justinpolygon
as code owners
not sure if our linter/parser was happy with the case statement so moved it back to an if statement
|
Closing this in favour of #567. The reason is that there are 10k+ tickers and we might get into a scenario where there are, or could. be, tickers like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue 1474. Customer was passing in a Class B designation on subscription/ticker string. The client side validation was unable to handle that. Correct fix is the change the subscribe method to take args as opposed to a string that we have to parse. But that would be a breaking change.