-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: cleaning the URL properly #136
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using filter directly on the splitted object instead of allocating an object and deleting its property to then retransform it into an array would save a few lines and avoid 2 object/array allocations.
Also, why do you define an anonymous function to call it right after ? |
|
This is reallocating an anonymous function at runtime every time you're executing it, and it's inconsistent with the rest of the code, pls define your function at global level (and with the function keyword instead of const = () =>...) |
Also the function name is backward |
Your memory tests are broken. |
Fixed on main. Don't mind it |
Doing this pull request because the handling of the access_token on auth breaks user experience. When there are other useful params in the path (e.g. ?docId=xxxxx) the cleanup in the code removes everything instead of just the access_token & refresh_token.
I fixed it by splitting the path and removing just the access_tokens and refresh_tokens and then rebuilding it.