服务不存在时，多个错误只返回第一个 #114
Open
服务不存在时，多个错误只返回第一个 #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@andrewshan look at this pr, OK? |
熔断consumer错误判断增加response的状态判断 (polarismesh#106)
reallovelei
force-pushed
the
fix/multi_err_94
branch
from
28f6fc0
to
f1fbfda
Compare
andrewshan
reviewed
Mar 28, 2023
| return model.NewSDKError(model.ErrCodeServerUserError, rawErr, | ||
| fmt.Sprintf("multierrs received for GetInstances request, serviceKey: %s", *dstService)) | ||
| // 只要有一个错误就立刻返回，避免所以错误都抛出来干扰 开发者的判断。 | ||
| for key, sdkErr := range sdkErrs { |
There was a problem hiding this comment.
建议这样，全部的错误信息还是要打印到日志上，方便定位，然后只返回第一个错误
daheige
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide issue(s) of this PR:
Fixes #94
To help us figure out who should review this PR, please put an X in all the areas that this PR affects.
Please check any characteristics that apply to this pull request.