Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: Provide a general fast path for arg_sort_multiple. #20444

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

perf: Provide a general fast path for arg_sort_multiple. #20444

wants to merge 3 commits into from
+326 −62

Conversation

coastalwhite
Copy link
Collaborator

WIP.

@coastalwhite
perf: Generalize the arg_sort fast path onto Column.
399a2c1 
This makes the implementation of `arg_sort` take the fast path in `Column`
before ever going into a specific SeriesTrait implementor. This now makes that
every type has the same fast path that gets taken when sorted. It also now
allows taking the fast path when `maintain_order=True`.

This PR needed to adjust some tests because they wrongly assumed things about
the output order of the sorting when `maintain_order=False`.
@coastalwhite
fix many tests
d569b9e
@coastalwhite
generalized fast paths for arg_sort_multiple
df7d3c3
@siddharth-vi
Copy link
Contributor

Seems like we will be changing current behavior of doing stable sort even when maintain_order=False( the default case).
IMO, although conceptually correct, this is a breaking change, as some users would be relying on this behavior. This is also evidenced by the fact that a lot of our tests also assumed this behavior.
Perhaps we can add a warning to users about this change ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritchie46 ritchie46 Awaiting requested review from ritchie46 ritchie46 will be requested when the pull request is marked ready for review ritchie46 is a code owner

@c-peters c-peters Awaiting requested review from c-peters c-peters will be requested when the pull request is marked ready for review c-peters is a code owner

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie will be requested when the pull request is marked ready for review alexander-beedie is a code owner

@MarcoGorelli MarcoGorelli Awaiting requested review from MarcoGorelli MarcoGorelli will be requested when the pull request is marked ready for review MarcoGorelli is a code owner

@reswqa reswqa Awaiting requested review from reswqa reswqa will be requested when the pull request is marked ready for review reswqa is a code owner

@orlp orlp Awaiting requested review from orlp orlp will be requested when the pull request is marked ready for review orlp is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
title needs formatting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@coastalwhite @siddharth-vi