Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(rust): Move gather kernels to polars-compute #20415

Merged
merged 4 commits into from
Dec 23, 2024
Merged

refactor(rust): Move gather kernels to polars-compute #20415

merged 4 commits into from
Dec 23, 2024

Conversation

nameexhaustion
Copy link
Collaborator

@nameexhaustion nameexhaustion commented Dec 23, 2024 •
edited
Loading

Fixes #19655

@github-actions github-actions bot added internal An internal refactor or improvement rust Related to Rust Polars labels Dec 23, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.99%. Comparing base (f242871) to head (21cbe7f).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #20415   +/-   ##
=======================================
  Coverage   78.98%   78.99%           
=======================================
  Files        1562     1562           
  Lines      220111   220103    -8     
  Branches     2486     2486           
=======================================
+ Hits       173855   173862    +7     
+ Misses      45683    45668   -15     
  Partials      573      573

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nameexhaustion nameexhaustion marked this pull request as ready for review December 23, 2024 10:29
@ritchie46
Copy link
Member

Nice!

@ritchie46 ritchie46 merged commit 2ae01fb into pola-rs:main Dec 23, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritchie46 ritchie46 Awaiting requested review from ritchie46 ritchie46 is a code owner

@orlp orlp Awaiting requested review from orlp orlp is a code owner

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

Assignees
No one assigned
Labels
internal An internal refactor or improvement rust Related to Rust Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add gather kernels to polars-compute
2 participants
@nameexhaustion @ritchie46