Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Properly handle to_physical_repr of nested types #20413

Merged
merged 5 commits into from
Dec 23, 2024

Conversation

coastalwhite
Copy link
Collaborator

Fixes #20308.

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Dec 23, 2024
///
/// This should be given the logical type in order to communicate Polars datatype information down
/// into the row encoding / decoding.
pub fn get_row_encoding_context(dtype: &DataType) -> Option<RowEncodingContext> {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a drive-by change. This name is much better for this function.

Copy link

codecov bot commented Dec 23, 2024

Codecov Report

Attention: Patch coverage is 96.73203% with 5 lines in your changes missing coverage. Please review.

Project coverage is 79.01%. Comparing base (62ebbe5) to head (4f7bc98).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-expr/src/groups/row_encoded.rs 0.00% 4 Missing ⚠️
...rates/polars-core/src/chunked_array/struct_/mod.rs 97.95% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20413      +/-   ##
==========================================
+ Coverage   78.97%   79.01%   +0.03%     
==========================================
  Files        1562     1562              
  Lines      220103   220105       +2     
  Branches     2486     2486              
==========================================
+ Hits       173821   173910      +89     
+ Misses      45709    45622      -87     
  Partials      573      573              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit d4145fd into pola-rs:main Dec 23, 2024
21 checks passed
@coastalwhite coastalwhite deleted the refactor/clean-re branch December 23, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decimals in Lists produce a wrong physical value
2 participants