Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix using new_columns in scan_csv with compressed file #20412

Merged
merged 2 commits into from
Dec 23, 2024

Conversation

nameexhaustion
Copy link
Collaborator

Fixes #19916

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Dec 23, 2024
Copy link

codecov bot commented Dec 23, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.96%. Comparing base (62ebbe5) to head (40e98ff).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-lazy/src/scan/csv.rs 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20412      +/-   ##
==========================================
- Coverage   78.97%   78.96%   -0.01%     
==========================================
  Files        1562     1562              
  Lines      220103   220096       -7     
  Branches     2486     2486              
==========================================
- Hits       173821   173809      -12     
- Misses      45709    45714       +5     
  Partials      573      573              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nameexhaustion nameexhaustion marked this pull request as ready for review December 23, 2024 08:45
@ritchie46 ritchie46 merged commit 6aaa98c into pola-rs:main Dec 23, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

scan_csv() using new_columns fails on compressed files
2 participants