Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Fix Expr.all description of Kleene logic #20409

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

docs: Fix Expr.all description of Kleene logic #20409

wants to merge 2 commits into from
+2 −2

Conversation

lukemanley
Copy link
Contributor

closes #17373

@github-actions github-actions bot added documentation Improvements or additions to documentation python Related to Python Polars rust Related to Rust Polars labels Dec 23, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.98%. Comparing base (62ebbe5) to head (29aa288).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #20409      +/-   ##
==========================================
+ Coverage   78.97%   78.98%   +0.01%     
==========================================
  Files        1562     1562              
  Lines      220103   220103              
  Branches     2486     2486              
==========================================
+ Hits       173821   173858      +37     
+ Misses      45709    45672      -37     
  Partials      573      573

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

rodrigogiraoserrao
rodrigogiraoserrao approved these changes Dec 23, 2024
View reviewed changes
Copy link
Collaborator

@rodrigogiraoserrao rodrigogiraoserrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This is a bit more concise than the suggestion in the linked issue. 🚀

@lukemanley lukemanley requested a review from orlp as a code owner December 23, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodrigogiraoserrao rodrigogiraoserrao rodrigogiraoserrao approved these changes

@ritchie46 ritchie46 Awaiting requested review from ritchie46 ritchie46 is a code owner

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

@MarcoGorelli MarcoGorelli Awaiting requested review from MarcoGorelli MarcoGorelli is a code owner

@reswqa reswqa Awaiting requested review from reswqa reswqa is a code owner

@orlp orlp Awaiting requested review from orlp orlp is a code owner

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

polars.Expr.all method description is unclear on ignore_nulls parameter logic
2 participants
@lukemanley @rodrigogiraoserrao